Repository navigation
Bump dependencies to fix security alerts - #433
Merged
Merged
Conversation
Dependencies (poetry.lock only, targeted update with Poetry 2.3.3; pyproject.toml and the lock content-hash are unchanged): aiohttp 3.13.5 -> 3.14.5 (with yarl 1.23.0 -> 1.25.1), multidict 6.7.1 -> 6.9.1, idna 3.11 -> 3.15, urllib3 2.6.3 -> 2.8.0, kafka-python 2.3.1 -> 2.3.3, anyio 4.13.0 -> 4.14.2, django 5.2.13 -> 5.2.18 (python < 3.12) and 6.0.4 -> 6.0.9 (python >= 3.12), sqlparse 0.5.5 -> 0.6.1, tornado 6.5.5 -> 6.5.10, pymongo 4.16.0 -> 4.18.3, starlette 1.0.0 -> 1.3.1, webob 1.8.9 -> 1.8.11, ujson 5.12.0 -> 5.13.0, werkzeug 3.1.8 -> 3.1.9, sanic 25.12.0 -> 25.12.1. setuptools stays at 81.0.0: pyramid imports pkg_resources, which setuptools >= 82 no longer ships. GitHub Actions, re-pinned to ASF-approved versions: actions/checkout v4 -> v7, actions/setup-python v5 -> v7, actions/upload-artifact v4 -> v7, actions/download-artifact v4 -> v8, tcort/github-action-markdown-link-check (unapproved SHA) -> v1.1.3, docker/login-action v4.2.0 -> v4.7.0, docker/setup-qemu-action v4.1.0 -> v4.4.0, docker/setup-buildx-action v4.1.0 -> v4.4.1, apache/skywalking-eyes header (2022 commit) -> v0.9.0. The `protocol` submodule gitlink is added to the license header paths-ignore because license-eye v0.9.0 fails to read it as a file. E2E: apache/skywalking-infra-e2e cf589b4 -> 56ac8be (current main, for the Docker 29 / containerd image store on ubuntu-26.04 runners). Its `contains` now matches each expected entry to a distinct actual item, so: - logs-list.yml: drop the never-matching placeholder entry that worked around apache/skywalking#8752, quote the log content with printf "%q" so the multi-line exception log renders as valid YAML, and fix the traceback regex (`Traceback \(most recent call last\)`). The exception log entry is now actually verified, independent of log order. - metrics-has-value.yml: drop the redundant `ge .value 0` entry; the check is still "at least one bucket >= 1".
wu-sheng
force-pushed
the
bump/security-deps-2026-11
branch
from
November 2, 2026 08:46
ec62152 to
161ff0c
Compare
kezhenxu94
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps locked dependencies to close open Dependabot alerts, and re-pins GitHub Actions to ASF-approved versions.
Dependencies (
poetry.lockonly)Targeted lock update with Poetry 2.3.3 (the version in the lock header).
pyproject.tomlis unchanged and the lockcontent-hashis unchanged. Versions stay on the lowest release line that has the fix, and every version supports the declared Python range>=3.10, <3.15.Supersedes #428 (django) and #430 (aiohttp).
Deliberately not bumped: setuptools (81.0.0, alerts CVE-2026-59890 / GHSA-xmj3-9gf7-h52w, fixed in 84.1.0). Every pyramid release imports
pkg_resourcesat module level; pyramid 2.1 declaressetuptools<82, and setuptools >= 82 no longer shipspkg_resources. The only lock that reaches setuptools 84.x downgrades pyramid to 2.0.2, which then fails withModuleNotFoundError: No module named 'pkg_resources'(checked locally with pyramid 2.0.2 + setuptools 84.1.0). #432 makes exactly that change, so this PR does not supersede it. Fixing this needs either a pyramid release withoutpkg_resourcesor dropping pyramid from the dev-onlypluginsgroup.GitHub Actions
actions/checkoutv4 -> v7actions/setup-pythonv5 -> v7 (v7 removes only thepip-installinput, which is not used here)actions/upload-artifactv4 -> v7actions/download-artifactv4 -> v8 (downloads are by name and of zipped artifacts, so v5's by-ID path change and v8's direct-download change do not apply)tcort/github-action-markdown-link-checke7c7a18(not on the ASF allowlist; Dead Link Checker runs on master currently end instartup_failure) ->e047c5b# v1.1.3docker/login-action650006c# v4.2.0 ->81c6f93# v4.7.0docker/setup-qemu-action0611638# v4.1.0 ->9901266# v4.4.0docker/setup-buildx-actiond7f5e7f# v4.1.0 ->f87e599# v4.4.1apache/skywalking-eyes/header501a28d(2022) ->a196742# v0.9.0. v0.9.0 fails withread protocol: is a directoryon the submodule gitlink, soprotocolis added topaths-ignorein.licenserc.yaml. The submodule is a separate Apache repo and was not header-checked before either.apache/skywalking-infra-e2ecf589b4->56ac8be(current main, for Docker 29 with the containerd image store on ubuntu-26.04 runners)Unchanged:
dorny/paths-filterceb8a2b# v4.0.3 is already the current approved SHA.Left as is: the plugin-test job still has its "Install docker-compose" (v1.29.2) fallback step. Nothing calls
docker-compose, because testcontainers usesdocker compose. The 36 plugin compose files still use the obsolete top-levelversion:key, which Compose v2 only warns about.E2E expected data
infra-e2e
56ac8beincludes apache/skywalking-infra-e2e#143:containsnow matches each expected entry to a distinct actual item. Two expected files depended on the old matching:tests/e2e/case/expected/logs-list.yml: removed the placeholder entry (ISHOULDNOTEXIST) and its FIXME, which worked around [INFRA-E2E][Bug] E2E mismatch actual data still pass the expected template skywalking#8752. The placeholder never matched. The file passed only because the multi-line exception log, rendered unquoted, broke the YAML of the expected entries and lowered the entry count. As a result the exception entry was never really checked. Its regexTraceback(most recent call last)could not match a real traceback anyway. Changes: eachcontentis now rendered withprintf "%q"so multi-line logs stay valid YAML, and the regex is nowTraceback \(most recent call last\).tests/e2e/case/expected/metrics-has-value.yml: removed thege .value 0entry. It overlapsge .value 1, and with distinct matching it made the check depend on bucket order (it failed when the only non-zero bucket came first, or when there was a single bucket). The check is still "some bucket is >= 1".Checked by running the
verifier.Verifyfunction from both infra-e2e pins on syntheticswctloutput:logs-list.yml: passes in all 6 orderings of the three logs. It fails when the exception log is missing, has the wrong level or has no traceback, when a warning is duplicated in its place, and when the basic-auth URL is not masked.logs-list.yml: passed in only 2 of the 6 orderings, and it passed when the exception log had the wrong level.The other expected files have only distinct
containsentries and are unchanged.License
This repo has no generated dist LICENSE. The top-level
LICENSEis plain Apache-2.0, and.licenserc.yamlhas nodependency:section.license-eye dependency resolve(v0.9.0) resolves no dependencies, so the dist LICENSE needs no change.Verified locally
poetry check --lock(Poetry 2.3.3): passedpoetry install --all-extras --with lint,make lint: flake8 passed. pylint reports E1101 only on the generatedskywalking/protocol/*_pb2_grpc.py. pylint, astroid, protobuf and grpcio are not changed by this PR.pylint --disable=all --enable=E0602,E0603,E1101 --ignore=protocol skywalking testspassed (10.00/10).poetry run pytest tests/unit: 135 passed, 1 failed. The failure istest_meter.py::test_counter_timer_decarator, a sleep-timing tolerance on macOS (0.0503 > 0.05). It fails the same way with the old aiohttp/idna/urllib3/kafka-python versions.pip checkreports nothing broken, and all of them import.license-eye header checkv0.9.0 with the updated.licenserc.yaml: passed (0 invalid).actionlintv1.7.12:actionlint -shellcheck= .github/workflows/*.yaml(shellcheck integration off) passed. Plainactionlintwith shellcheck exits 1 on SC2086/SC2069/SC2129 findings inrun:scripts (CI.yamllines 122 and 185,publish-docker.yamlline 42). The same 14 findings appear onmaster; this PR does not touch those scripts.cf589b4and56ac8be) against syntheticswctloutput, see the E2E section.Not verified locally: Docker-based plugin tests and the real E2E runs. CI on this PR covers them. E2E was green on master in the 2026-10-31 and 2026-11-01 scheduled runs.